linux-kernel - Re: [PATCH] checkpatch: avoid warning about Possible repeated word: 'Google'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 13 Oct 2023 11:11:42 -0700
From:   Joe Perches <joe@...ches.com>
To:     Jakub Kicinski <kuba@...nel.org>, linux-kernel@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>
Cc:     apw@...onical.com, dwaipayanray1@...il.com, lukas.bulwahn@...il.com
Subject: Re: [PATCH] checkpatch: avoid warning about Possible repeated word:
 'Google'

On Fri, 2023-10-13 at 10:27 -0700, Jakub Kicinski wrote:
> syzbot stack traces often come with the following line:
> 
>  Hardware name: Google Google Compute Engine/Google Compute Engine...

If you must, you must, but I wonder if code to ignore
syzbot blocks might be more sensible.  I don't see
obvious syzbot start/end block markers though.


> This generates the repeated word warning from checkpatch.
> It hit 49 times in the last 6 months in networking
> (false-positive rate of 0.34%). Mute the warning for "Google",
> there's no other word which comes close to being this clear
> cut false-positive in our traffic.
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
> CC: apw@...onical.com
> CC: joe@...ches.com
> CC: dwaipayanray1@...il.com
> CC: lukas.bulwahn@...il.com
> ---
>  scripts/checkpatch.pl | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 7d16f863edf1..c99f8f93cb4c 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -3524,6 +3524,8 @@ sub process {
>  
>  				next if (lc($first) ne lc($second));
>  				next if ($first eq 'long');
> +				# syzbot reports contain "Hardware name: Google Google Compute Engine"
> +				next if ($first eq 'Google');
>  
>  				# check for character before and after the word matches
>  				my $start_char = '';