linux-kernel - Re: [PATCH] scripts/show_delta: add __main_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKwvOdneBDDCeg-GzKMpWmvqQCC53KcaV_GAF1JioCJdCtBkxw@mail.gmail.com>
Date:   Fri, 13 Oct 2023 13:27:24 -0700
From:   Nick Desaulniers <ndesaulniers@...gle.com>
To:     Hu Haowen <2023002089@...k.tyut.edu.cn>
Cc:     gregkh@...uxfoundation.org, masahiroy@...nel.org,
        akpm@...ux-foundation.org, n.schier@....de, ojeda@...nel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scripts/show_delta: add __main__ judgement before main code

On Fri, Oct 13, 2023 at 6:29 AM Hu Haowen <2023002089@...k.tyut.edu.cn> wrote:
>
> When doing Python programming it is a nice convention to insert the if
> statement `if __name__ == "__main__":` before any main code that does
> actual functionalities to ensure the code will be executed only as a
> script rather than as an imported module. Hence attach the missing
> judgement to show_delta.
>
> Signed-off-by: Hu Haowen <2023002089@...k.tyut.edu.cn>

Thanks for the patch!
Reviewed-by: Nick Desaulniers <ndesaulniers@...gle.com>

> ---
>  scripts/show_delta | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/show_delta b/scripts/show_delta
> index 28e67e178194..291ad65e3089 100755
> --- a/scripts/show_delta
> +++ b/scripts/show_delta
> @@ -125,4 +125,5 @@ def main():
>         for line in lines:
>                 print (convert_line(line, base_time),)
>
> -main()
> +if __name__ == "__main__":
> +       main()
> --
> 2.34.1
>


-- 
Thanks,
~Nick Desaulniers