linux-kernel - Re: [PATCH] scripts/show_delta: add __main_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72npYE=W6B5Ln42Tr-Z8kPQihQit3k=C_wdO1kcx_Dvpxw@mail.gmail.com>
Date:   Sat, 14 Oct 2023 12:15:05 +0200
From:   Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To:     Hu Haowen <2023002089@...k.tyut.edu.cn>
Cc:     gregkh@...uxfoundation.org, masahiroy@...nel.org,
        akpm@...ux-foundation.org, ndesaulniers@...gle.com,
        n.schier@....de, ojeda@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scripts/show_delta: add __main__ judgement before main code

On Fri, Oct 13, 2023 at 3:29 PM Hu Haowen <2023002089@...k.tyut.edu.cn> wrote:
>
> When doing Python programming it is a nice convention to insert the if
> statement `if __name__ == "__main__":` before any main code that does
> actual functionalities to ensure the code will be executed only as a
> script rather than as an imported module. Hence attach the missing
> judgement to show_delta.
>
> Signed-off-by: Hu Haowen <2023002089@...k.tyut.edu.cn>

I am not sure why I was Cc'd, but the patch looks fine :)

Reviewed-by: Miguel Ojeda <ojeda@...nel.org>

Cheers,
Miguel