linux-kernel - Re: [PATCH] scripts/show_delta: add __main_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <556752fd-0ae4-45b5-bfb4-5777c8302d48@link.tyut.edu.cn>
Date:   Sun, 15 Oct 2023 01:19:00 +0800
From:   Hu Haowen <2023002089@...k.tyut.edu.cn>
To:     Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
Cc:     gregkh@...uxfoundation.org, masahiroy@...nel.org,
        akpm@...ux-foundation.org, ndesaulniers@...gle.com,
        n.schier@....de, ojeda@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scripts/show_delta: add __main__ judgement before main
 code


On 2023/10/14 18:15, Miguel Ojeda wrote:
> On Fri, Oct 13, 2023 at 3:29 PM Hu Haowen <2023002089@...k.tyut.edu.cn> wrote:
>> When doing Python programming it is a nice convention to insert the if
>> statement `if __name__ == "__main__":` before any main code that does
>> actual functionalities to ensure the code will be executed only as a
>> script rather than as an imported module. Hence attach the missing
>> judgement to show_delta.
>>
>> Signed-off-by: Hu Haowen <2023002089@...k.tyut.edu.cn>
> I am not sure why I was Cc'd, but the patch looks fine :)


Sorry for troubling you. I have just executed the get_maintainer script
to get the maintainer for the file I'm making the patch toward, with
the result that this file is not maintained by anyone. Consequently I
immediately ran again on the scripts directory, and obtained adequate
information on major commiters of scripts, adding them to the Cc list.

After all, it's nice of you to have ensured the quality of my patch. :)


> Reviewed-by: Miguel Ojeda <ojeda@...nel.org>
>
> Cheers,
> Miguel
>