linux-kernel - Re: [PATCH] tty: gdm724x: Fix coding style checkpatch warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 12 Oct 2023 22:35:06 -0700
From:   Soumya Negi <soumya.negi97@...il.com>
To:     Julia Lawall <julia.lawall@...ia.fr>
Cc:     Jonathan Kim <jonathankim@...semi.com>,
        Dean ahn <deanahn@...semi.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        outreachy@...ts.linux.dev, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tty: gdm724x: Fix coding style checkpatch warnings

On Fri, Oct 13, 2023 at 07:20:08AM +0200, Julia Lawall wrote:
> 
> 
> On Thu, 12 Oct 2023, Soumya Negi wrote:
> 
> > Add blank line after declaration & match alignment with open parenthesis.
> > Issue found by checkpatch.pl
> 
> This seems like two completely unrelated issues.
> 
> julia

Hi Julia,

I got it. Will send two separate patches for each type of code cleanup.

- Soumya

> >
> > Signed-off-by: Soumya Negi <soumya.negi97@...il.com>
> > ---
> >  drivers/staging/gdm724x/gdm_tty.c | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/staging/gdm724x/gdm_tty.c b/drivers/staging/gdm724x/gdm_tty.c
> > index 32b2e817ff04..0c61eaff6122 100644
> > --- a/drivers/staging/gdm724x/gdm_tty.c
> > +++ b/drivers/staging/gdm724x/gdm_tty.c
> > @@ -160,6 +160,7 @@ static ssize_t gdm_tty_write(struct tty_struct *tty, const u8 *buf, size_t len)
> >
> >  	while (remain) {
> >  		size_t sending_len = min_t(size_t, MUX_TX_MAX_SIZE, remain);
> > +
> >  		gdm->tty_dev->send_func(gdm->tty_dev->priv_dev,
> >  					(void *)(buf + sent_len),
> >  					sending_len,
> > @@ -271,8 +272,8 @@ int register_lte_tty_driver(void)
> >  	int ret;
> >
> >  	for (i = 0; i < TTY_MAX_COUNT; i++) {
> > -		tty_driver = tty_alloc_driver(GDM_TTY_MINOR,
> > -				TTY_DRIVER_REAL_RAW | TTY_DRIVER_DYNAMIC_DEV);
> > +		tty_driver = tty_alloc_driver(GDM_TTY_MINOR, TTY_DRIVER_REAL_RAW |
> > +					      TTY_DRIVER_DYNAMIC_DEV);
> >  		if (IS_ERR(tty_driver))
> >  			return PTR_ERR(tty_driver);
> >
> > --
> > 2.42.0
> >
> >
> >