linux-kernel - Re: [PATCH] wifi: wilc1000: use vmm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f615b0895135489a2555d898afdcfbfa@kernel.org>
Date:   Fri, 13 Oct 2023 11:24:31 +0200
From:   Michael Walle <mwalle@...nel.org>
To:     Alexis Lothoré <alexis.lothore@...tlin.com>
Cc:     Claudiu Beznea <claudiu.beznea@...on.dev>,
        Kalle Valo <kvalo@...nel.org>, linux-wireless@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
        Ajay Singh <ajay.kathat@...rochip.com>, stable@...r.kernel.org,
        heiko.thiery@...il.com
Subject: Re: [PATCH] wifi: wilc1000: use vmm_table as array in wilc struct

Hi,

Am 2023-10-13 10:26, schrieb Alexis Lothoré:
> From: Ajay Singh <ajay.kathat@...rochip.com>
> 
> Enabling KASAN and running some iperf tests raises some memory issues 
> with
> vmm_table:
> 
> BUG: KASAN: slab-out-of-bounds in wilc_wlan_handle_txq+0x6ac/0xdb4
> Write of size 4 at addr c3a61540 by task wlan0-tx/95
> 
> KASAN detects that we are writing data beyond range allocated to 
> vmm_table.
> There is indeed a mismatch between the size passed to allocator in
> wilc_wlan_init, and the range of possible indexes used later: 
> allocation
> size is missing a multiplication by sizeof(u32)

Nice catch.

> While at it, instead of simply multiplying the allocation size, do not 
> keep
> dedicated dynamic allocation for vmm_table: define it as an array with 
> the
> relevant size in wilc struct, which is already dynamically allocated
> 
> Fixes: 40b717bfcefa ("wifi: wilc1000: fix DMA on stack objects")
> Cc: stable@...r.kernel.org
> Signed-off-by: Ajay Singh <ajay.kathat@...rochip.com>
> Signed-off-by: Alexis Lothoré <alexis.lothore@...tlin.com>

Looks good to me. But you'll change the alignment of the table, not sure
if that matters for some DMA controllers.

-michael