linux-kernel - Re: [PATCH] wifi: wilc1000: use vmm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <969d7010-736f-46cb-98df-0a3ff6be867c@bootlin.com>
Date:   Mon, 16 Oct 2023 08:59:22 +0200
From:   Alexis Lothoré <alexis.lothore@...tlin.com>
To:     Michael Walle <mwalle@...nel.org>
Cc:     Claudiu Beznea <claudiu.beznea@...on.dev>,
        Kalle Valo <kvalo@...nel.org>, linux-wireless@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
        Ajay Singh <ajay.kathat@...rochip.com>, stable@...r.kernel.org,
        heiko.thiery@...il.com
Subject: Re: [PATCH] wifi: wilc1000: use vmm_table as array in wilc struct

Hello Michael,

On 10/13/23 11:24, Michael Walle wrote:
>> Fixes: 40b717bfcefa ("wifi: wilc1000: fix DMA on stack objects")
>> Cc: stable@...r.kernel.org
>> Signed-off-by: Ajay Singh <ajay.kathat@...rochip.com>
>> Signed-off-by: Alexis Lothoré <alexis.lothore@...tlin.com>
> 
> Looks good to me. But you'll change the alignment of the table, not sure
> if that matters for some DMA controllers.

Thanks for the review.
Indeed, I may have overlooked that point. I am not sure either how much of an
issue it could be, but checking back the driver history on lore, I see that it
has already been mentioned, so let's be safe and keep a dedicated kzalloc for
vmm_table to make sure its address is safe to use with DMA.
I will send the corresponding v2.

Thanks,
Alexis

> 
> -michael

-- 
Alexis Lothoré, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com