linux-kernel - Re: [PATCH] crypto: hisilicon/qm - alloc buffer to set and get xqc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZSkebr0vRhNelyZL@gondor.apana.org.au>
Date:   Fri, 13 Oct 2023 18:39:42 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Weili Qian <qianweili@...wei.com>
Cc:     linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
        liulongfang@...wei.com
Subject: Re: [PATCH] crypto: hisilicon/qm - alloc buffer to set and get xqc

On Sun, Oct 08, 2023 at 08:36:17PM +0800, Weili Qian wrote:
> If the temporarily applied memory is used to set or get the xqc
> information, the driver releases the memory immediately after the
> hardware mailbox operation time exceeds the driver waiting time.
> However, the hardware does not cancel the operation, so the hardware
> may write data to released memory.
> 
> Therefore, when the driver is bound to a device, the driver reserves
> memory for the xqc configuration. The subsequent xqc configuration
> uses the reserved memory to prevent hardware from accessing the
> released memory.
> 
> Signed-off-by: Weili Qian <qianweili@...wei.com>
> ---
>  drivers/crypto/hisilicon/debugfs.c   |  75 +++---
>  drivers/crypto/hisilicon/qm.c        | 332 ++++++++++++---------------
>  drivers/crypto/hisilicon/qm_common.h |   5 +-
>  include/linux/hisi_acc_qm.h          |  13 ++
>  4 files changed, 191 insertions(+), 234 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt