[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ce6c3d81-d75d-40e7-a6df-7abd4e8250a5@kadam.mountain>
Date: Fri, 13 Oct 2023 14:19:44 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Calvince Otieno <calvncce@...il.com>
Cc: outreachy@...ts.linux.dev, linux-kernel@...r.kernel.org,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Luke Koch <lu.ale.koch@...il.com>,
Bagas Sanjaya <bagasdotme@...il.com>,
Simon Horman <horms@...nel.org>, linux-staging@...ts.linux.dev
Subject: Re: [PATCH v6] staging: wlan-ng: replace strncpy() with strscpy()
On Fri, Oct 13, 2023 at 02:15:43PM +0300, Calvince Otieno wrote:
> Checkpatch suggests the use of strscpy() instead of strncpy().
> The advantages are that it always adds a NUL terminator and it prevents
> a read overflow if the src string is not properly terminated. One
> potential disadvantage is that it doesn't zero pad the string like
> strncpy() does.
> In this code, strscpy() and strncpy() are equivalent and it does not
> affect runtime behavior. The string is zeroed on the line before
> using memset(). The resulting string was always NUL terminated and
> PRISM2_USB_FWFILE is string literal "prism2_ru.fw" so it's NUL
> terminated.
> However, even though using strscpy() does not fix any bugs, it's
> still nicer and makes checkpatch happy.
>
> Signed-off-by: Calvince Otieno <calvncce@...il.com>
> ---
It's still white space damaged and can't apply. :/ Try save the email
and do `cat raw_email.txt | patch -p1`.
regards,
dan carpenter
Powered by blists - more mailing lists