linux-kernel - Re: [PATCH v6] staging: wlan-ng: replace strncpy() with strscpy()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 13 Oct 2023 20:28:30 +0700
From:   Bagas Sanjaya <bagasdotme@...il.com>
To:     Dan Carpenter <dan.carpenter@...aro.org>,
        Calvince Otieno <calvncce@...il.com>
Cc:     outreachy@...ts.linux.dev, linux-kernel@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Luke Koch <lu.ale.koch@...il.com>,
        Simon Horman <horms@...nel.org>, linux-staging@...ts.linux.dev
Subject: Re: [PATCH v6] staging: wlan-ng: replace strncpy() with strscpy()

On 13/10/2023 18:19, Dan Carpenter wrote:
> On Fri, Oct 13, 2023 at 02:15:43PM +0300, Calvince Otieno wrote:
>> Checkpatch suggests the use of strscpy() instead of strncpy().
>> The advantages are that it always adds a NUL terminator and it prevents
>> a read overflow if the src string is not properly terminated. One
>> potential disadvantage is that it doesn't zero pad the string like
>> strncpy() does.
>> In this code, strscpy() and strncpy() are equivalent and it does not
>> affect runtime behavior. The string is zeroed on the line before
>> using memset(). The resulting string was always NUL terminated and
>> PRISM2_USB_FWFILE is string literal "prism2_ru.fw" so it's NUL
>> terminated.
>> However, even though using strscpy() does not fix any bugs, it's
>> still nicer and makes checkpatch happy.
>>
>> Signed-off-by: Calvince Otieno <calvncce@...il.com>
>> ---
> 
> It's still white space damaged and can't apply.  :/  Try save the email
> and do `cat raw_email.txt | patch -p1`.
> 

And better yet, use git-send-email(1) to send patches. But don't rush,
as you have sent five versions of this patch today. Please wait for a day
to a week and then reroll.

Thanks.

-- 
An old man doll... just what I always wanted! - Clara