linux-kernel - Re: [PATCH 1/2] tty: gdm724x: Match alignment with open parenthesis

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52732a88-7f40-4ce4-b75b-dded9827c1f0@kadam.mountain>
Date:   Sat, 14 Oct 2023 10:38:22 +0300
From:   Dan Carpenter <dan.carpenter@...aro.org>
To:     Soumya Negi <soumya.negi97@...il.com>
Cc:     Jonathan Kim <jonathankim@...semi.com>,
        Dean ahn <deanahn@...semi.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        outreachy@...ts.linux.dev, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] tty: gdm724x: Match alignment with open parenthesis

On Fri, Oct 13, 2023 at 02:13:26PM -0700, Soumya Negi wrote:
> On Fri, Oct 13, 2023 at 11:57:40AM +0300, Dan Carpenter wrote:
> > On Fri, Oct 13, 2023 at 01:26:34AM -0700, Soumya Negi wrote:
> > > Fix CHECK: Alignment should match open parenthesis
> > > Issue found by checkpatch.pl
> > > 
> > > Signed-off-by: Soumya Negi <soumya.negi97@...il.com>
> > > ---
> > >  drivers/staging/gdm724x/gdm_tty.c | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/drivers/staging/gdm724x/gdm_tty.c b/drivers/staging/gdm724x/gdm_tty.c
> > > index 32b2e817ff04..4e5cac76db58 100644
> > > --- a/drivers/staging/gdm724x/gdm_tty.c
> > > +++ b/drivers/staging/gdm724x/gdm_tty.c
> > > @@ -271,8 +271,8 @@ int register_lte_tty_driver(void)
> > >  	int ret;
> > >  
> > >  	for (i = 0; i < TTY_MAX_COUNT; i++) {
> > > -		tty_driver = tty_alloc_driver(GDM_TTY_MINOR,
> > > -				TTY_DRIVER_REAL_RAW | TTY_DRIVER_DYNAMIC_DEV);
> > > +		tty_driver = tty_alloc_driver(GDM_TTY_MINOR, TTY_DRIVER_REAL_RAW |
> > > +					      TTY_DRIVER_DYNAMIC_DEV);
> > 
> > I prefered the original code.  It was more readable.
> > 
> > regards,
> > dan carpenter
> Hi Dan,
> 
> Noted. I'm curious what happens when some of the patches in a patchset
> are acceptable and some are not. Is everything disregarded by
> maintainers or are the good patches cherry-picked from the set?

Most of the time, you should just resend the series.  Sometimes a
maintainer will take the first few patches and then when they hit one
that can't be merged they'll stop.  So you should try to organize your
patchsets from fixes first, then cleanups and then least controversial
to most controversial.  Except people might be annoyed if it looks like
you're hiding a really controversial one at the end of a long series.

regards,
dan carpenter