[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <35984b5f-d4f5-4d45-9e17-b41140ff78e0@infradead.org>
Date: Sun, 15 Oct 2023 08:35:17 -0700
From: Randy Dunlap <rdunlap@...radead.org>
To: Yussef Dalton <yussef.dalton@...il.com>, tzimmermann@...e.de
Cc: javierm@...hat.com, dri-devel@...ts.freedesktop.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/tiny: print 'struct resource *' correctly
On 10/15/23 06:11, Yussef Dalton wrote:
> Since format specifier %pr refers to a 'struct resource *', there is no
> need to take the address of the 'res' variable since it is already of
> type 'struct resource *'.
>
> Signed-off-by: Yussef Dalton <yussef.dalton@...il.com>
Reviewed-by: Randy Dunlap <rdunlap@...radead.org>
Thanks.
> ---
> drivers/gpu/drm/tiny/ofdrm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/tiny/ofdrm.c b/drivers/gpu/drm/tiny/ofdrm.c
> index 2d999a0facde..6372ab383747 100644
> --- a/drivers/gpu/drm/tiny/ofdrm.c
> +++ b/drivers/gpu/drm/tiny/ofdrm.c
> @@ -1208,13 +1208,13 @@ static struct ofdrm_device *ofdrm_device_create(struct drm_driver *drv,
>
> ret = devm_aperture_acquire_from_firmware(dev, fb_pgbase, fb_pgsize);
> if (ret) {
> - drm_err(dev, "could not acquire memory range %pr: error %d\n", &res, ret);
> + drm_err(dev, "could not acquire memory range %pr: error %d\n", res, ret);
> return ERR_PTR(ret);
> }
>
> mem = devm_request_mem_region(&pdev->dev, fb_pgbase, fb_pgsize, drv->name);
> if (!mem) {
> - drm_warn(dev, "could not acquire memory region %pr\n", &res);
> + drm_warn(dev, "could not acquire memory region %pr\n", res);
> return ERR_PTR(-ENOMEM);
> }
>
--
~Randy
Powered by blists - more mailing lists