linux-kernel - Re: [PATCH] drm/tiny: print 'struct resource *' correctly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <78ec36c9-5e87-4c83-bdbf-5680f6eaff4c@gmail.com>
Date: Sun, 17 Dec 2023 00:12:18 +0100
From: Yussef Dalton <yussef.dalton@...il.com>
To: Randy Dunlap <rdunlap@...radead.org>, tzimmermann@...e.de
Cc: javierm@...hat.com, dri-devel@...ts.freedesktop.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/tiny: print 'struct resource *' correctly

On 10/15/23 17:35, Randy Dunlap wrote:
> 
> 
> On 10/15/23 06:11, Yussef Dalton wrote:
>> Since format specifier %pr refers to a 'struct resource *', there is no
>> need to take the address of the 'res' variable since it is already of
>> type 'struct resource *'.
>>
>> Signed-off-by: Yussef Dalton <yussef.dalton@...il.com>
> 
> Reviewed-by: Randy Dunlap <rdunlap@...radead.org>
> 
> Thanks.
> 
>> ---
>>   drivers/gpu/drm/tiny/ofdrm.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/tiny/ofdrm.c b/drivers/gpu/drm/tiny/ofdrm.c
>> index 2d999a0facde..6372ab383747 100644
>> --- a/drivers/gpu/drm/tiny/ofdrm.c
>> +++ b/drivers/gpu/drm/tiny/ofdrm.c
>> @@ -1208,13 +1208,13 @@ static struct ofdrm_device *ofdrm_device_create(struct drm_driver *drv,
>>   
>>   	ret = devm_aperture_acquire_from_firmware(dev, fb_pgbase, fb_pgsize);
>>   	if (ret) {
>> -		drm_err(dev, "could not acquire memory range %pr: error %d\n", &res, ret);
>> +		drm_err(dev, "could not acquire memory range %pr: error %d\n", res, ret);
>>   		return ERR_PTR(ret);
>>   	}
>>   
>>   	mem = devm_request_mem_region(&pdev->dev, fb_pgbase, fb_pgsize, drv->name);
>>   	if (!mem) {
>> -		drm_warn(dev, "could not acquire memory region %pr\n", &res);
>> +		drm_warn(dev, "could not acquire memory region %pr\n", res);
>>   		return ERR_PTR(-ENOMEM);
>>   	}
>>   
> 

Hi,

Sorry for the bump, but is there any news on my patch?

Regards,

Yussef