[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ca0690eb-1f3b-4508-9cf2-079b5ad12e26@suse.com>
Date: Mon, 16 Oct 2023 09:13:29 +0200
From: Juergen Gross <jgross@...e.com>
To: Viresh Kumar <viresh.kumar@...aro.org>,
Stefano Stabellini <sstabellini@...nel.org>,
Oleksandr Tyshchenko <oleksandr_tyshchenko@...m.com>
Cc: Vincent Guittot <vincent.guittot@...aro.org>,
Alex Bennée <alex.bennee@...aro.org>,
stratos-dev@...lists.linaro.org,
Erik Schilling <erik.schilling@...aro.org>,
Manos Pitsidianakis <manos.pitsidianakis@...aro.org>,
Mathieu Poirier <mathieu.poirier@...aro.org>,
Arnd Bergmann <arnd@...nel.org>,
xen-devel@...ts.xenproject.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V4 1/4] xen: Make struct privcmd_irqfd's layout
architecture independent
On 16.10.23 09:11, Viresh Kumar wrote:
> Using indirect pointers in an ioctl command argument means that the
> layout is architecture specific, in particular we can't use the same one
> from 32-bit compat tasks. The general recommendation is to have __u64
> members and use u64_to_user_ptr() to access it from the kernel if we are
> unable to avoid the pointers altogether.
>
> Fixes: f8941e6c4c71 ("xen: privcmd: Add support for irqfd")
> Reported-by: Arnd Bergmann <arnd@...nel.org>
> Closes: https://lore.kernel.org/all/268a2031-63b8-4c7d-b1e5-8ab83ca80b4a@app.fastmail.com/
> Signed-off-by: Viresh Kumar <viresh.kumar@...aro.org>
Reviewed-by: Juergen Gross <jgross@...e.com>
Juergen
Download attachment "OpenPGP_0xB0DE9DD628BF132F.asc" of type "application/pgp-keys" (3099 bytes)
Download attachment "OpenPGP_signature.asc" of type "application/pgp-signature" (496 bytes)
Powered by blists - more mailing lists