linux-kernel - Re: [PATCH V4 2/4] xen: irqfd: Use _IOW instead of the internal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b129e6f5-ad9d-4267-b058-29a64f8f1d59@suse.com>
Date:   Mon, 16 Oct 2023 09:14:46 +0200
From:   Juergen Gross <jgross@...e.com>
To:     Viresh Kumar <viresh.kumar@...aro.org>,
        Stefano Stabellini <sstabellini@...nel.org>,
        Oleksandr Tyshchenko <oleksandr_tyshchenko@...m.com>
Cc:     Vincent Guittot <vincent.guittot@...aro.org>,
        Alex Bennée <alex.bennee@...aro.org>,
        stratos-dev@...lists.linaro.org,
        Erik Schilling <erik.schilling@...aro.org>,
        Manos Pitsidianakis <manos.pitsidianakis@...aro.org>,
        Mathieu Poirier <mathieu.poirier@...aro.org>,
        Arnd Bergmann <arnd@...nel.org>,
        xen-devel@...ts.xenproject.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V4 2/4] xen: irqfd: Use _IOW instead of the internal
 _IOC() macro

On 16.10.23 09:11, Viresh Kumar wrote:
> _IOC() an internal helper that we should not use in driver code.  In
> particular, we got the data direction wrong here, which breaks a number
> of tools, as having "_IOC_NONE" should never be paired with a nonzero
> size.
> 
> Use _IOW() instead.
> 
> Fixes: f8941e6c4c71 ("xen: privcmd: Add support for irqfd")
> Reported-by: Arnd Bergmann <arnd@...nel.org>
> Closes: https://lore.kernel.org/all/268a2031-63b8-4c7d-b1e5-8ab83ca80b4a@app.fastmail.com/
> Signed-off-by: Viresh Kumar <viresh.kumar@...aro.org>

Reviewed-by: Juergen Gross <jgross@...e.com>


Juergen


Download attachment "OpenPGP_0xB0DE9DD628BF132F.asc" of type "application/pgp-keys" (3099 bytes)

Download attachment "OpenPGP_signature.asc" of type "application/pgp-signature" (496 bytes)