linux-kernel - Re: [PATCH v3 2/7] tty: 8250: Add support for additional Brainboxes UC cards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DU0PR02MB7899461DC8DD0CBD02EAABDAC4D7A@DU0PR02MB7899.eurprd02.prod.outlook.com>
Date:   Mon, 16 Oct 2023 08:34:36 +0100
From:   Cameron Williams <cang1@...e.co.uk>
To:     Jiri Slaby <jirislaby@...nel.org>
Cc:     gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
        linux-serial@...r.kernel.org
Subject: Re: [PATCH v3 2/7] tty: 8250: Add support for additional Brainboxes
 UC cards

On Mon, Oct 16, 2023 at 07:40:03AM +0200, Jiri Slaby wrote:
> On 15. 10. 23, 19:10, Cameron Williams wrote:
> > Add support for additional revisions/IDs of the Brainboxes UC
> > range of serial cards.
> > 
> > Add: Additional UC-235/UC-246, UC-302, UC-313, UC-346, UC-357 card IDs
> > Add: UC-253/UC-734 , UC-607, UC-836 cards
> > Fix: UC-431 variant note removed as it is a 3-port card, and there is
> > no generic 3-port configuration available.
> 
> So can it be fixed instead of removed?
>
By fixed, do you mean implement a generic 3-port configuration?
I could look into it, it would be nice to have all of the cards in the
range supported, but I wanted to avoid adding a specific configuration
only used by one niche card.
If you mean fixed as in change the wording a little bit and add a Fixes:
tag, then I can do that too.
> > Fix: UC-257 moved to parport_serial as it is a serial/LPT card.
> 
> So this patch deserves a Fixes tag and should go to stable as well?
> 
> Anyway, could you split this into fixes and additions (ie. 2 patches)?
> 
Noted.
> thanks,
> -- 
> js
> suse labs
>