linux-kernel - Re: [PATCH V1 1/4] dt-bindings: crypto: qcom,prng: document SA8775P

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <hgtbdvbhoxwib4ywkd6pdxpcywgudb2b23tvlmaxaggeqgsghg@s6qetpw755rw>
Date:   Sun, 15 Oct 2023 19:41:57 -0700
From:   Bjorn Andersson <andersson@...nel.org>
To:     Om Prakash Singh <quic_omprsing@...cinc.com>
Cc:     neil.armstrong@...aro.org, konrad.dybcio@...aro.org,
        agross@...nel.org, conor+dt@...nel.org, davem@...emloft.net,
        devicetree@...r.kernel.org, herbert@...dor.apana.org.au,
        krzysztof.kozlowski+dt@...aro.org, linux-arm-msm@...r.kernel.org,
        linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
        marijn.suijten@...ainline.org, robh+dt@...nel.org, vkoul@...nel.org
Subject: Re: [PATCH V1 1/4] dt-bindings: crypto: qcom,prng: document SA8775P

On Mon, Oct 16, 2023 at 01:08:58AM +0530, Om Prakash Singh wrote:
> Document SA8775P compatible for the True Random Number Generator.
> 
> Signed-off-by: Om Prakash Singh <quic_omprsing@...cinc.com>
> ---
>  Documentation/devicetree/bindings/crypto/qcom,prng.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/crypto/qcom,prng.yaml b/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
> index 633993f801c6..85e6b1c199f5 100644
> --- a/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
> +++ b/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
> @@ -19,6 +19,7 @@ properties:
>            - enum:
>                - qcom,sm8450-trng
>                - qcom,sm8550-trng
> +              - qcom,sa8775p-trng

Please maintain the alphabetical sort order of entries like this.


On the two DeviceTree patches, we keep nodes sorted by address, followed
by node name, and then label. And we keep the address padded to 8 digits
to make it easier to keep them sorted. I've corrected that and picked
the 2 (i.e. all 4) DeviceTree patches.

So please fix above, and resubmit the two binding updates from this
series (and you can submit that as one change, no need to keep as
separate patches).

Regards,
Bjorn

>            - const: qcom,trng
>  
>    reg:
> -- 
> 2.25.1
>