linux-kernel - Re: [PATCH bpf-next v3] selftests/bpf: Use pkg-config to determine ld flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ecb37173-4b49-466b-b92d-4ff710eee998@daynix.com>
Date:   Mon, 16 Oct 2023 22:08:21 +0900
From:   Akihiko Odaki <akihiko.odaki@...nix.com>
To:     Daniel Borkmann <daniel@...earbox.net>
Cc:     Andrii Nakryiko <andrii@...nel.org>,
        Mykola Lysenko <mykolal@...com>,
        Alexei Starovoitov <ast@...nel.org>,
        Martin KaFai Lau <martin.lau@...ux.dev>,
        Song Liu <song@...nel.org>,
        Yonghong Song <yonghong.song@...ux.dev>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...nel.org>,
        Stanislav Fomichev <sdf@...gle.com>,
        Hao Luo <haoluo@...gle.com>, Jiri Olsa <jolsa@...nel.org>,
        Shuah Khan <shuah@...nel.org>, Nick Terrell <terrelln@...com>,
        bpf@...r.kernel.org, linux-kselftest@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH bpf-next v3] selftests/bpf: Use pkg-config to determine ld
 flags

On 2023/10/16 21:52, Daniel Borkmann wrote:
> On 10/16/23 2:43 PM, Akihiko Odaki wrote:
>> When linking statically, libraries may require other dependencies to be
>> included to ld flags. In particular, libelf may require libzstd. Use
>> pkg-config to determine such dependencies.
>>
>> Signed-off-by: Akihiko Odaki <akihiko.odaki@...nix.com>
>> ---
>> V2 -> V3: Added missing "echo".
>> V1 -> V2: Implemented fallback, referring to HOSTPKG_CONFIG.
> 
> Same issue in v3. Please don't resend your patches too quickly, but 
> properly set up an
> environment where you can test that this fallback works first :
> 
> https://github.com/kernel-patches/bpf/actions/runs/6533309175/job/17738285759

I think you are looking at a wrong run. The run checks out:
https://github.com/kernel-patches/bpf/commit/0c184cb0b561d2fb60b2dc79c2917cd7ff8cd8a2

This is v2. I think the correct one is:
https://github.com/kernel-patches/bpf/actions/runs/6533797864

That said, I found spurious error messages with the run. I tested it by 
setting PKG_CONFIG=false, but I should have tested it with 
PKG_CONFIG=a-command-that-does-not-exist. Now I sent v4, which does no 
longer emit noisy error messages and is properly tested.