linux-kernel - Re: [PATCH] mm/swap: avoid a xa load for swapout path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZS34v5PGWhCdmBjI@casper.infradead.org>
Date:   Tue, 17 Oct 2023 04:00:15 +0100
From:   Matthew Wilcox <willy@...radead.org>
To:     Kairui Song <kasong@...cent.com>
Cc:     linux-mm@...ck.org, Andrew Morton <akpm@...ux-foundation.org>,
        "Huang, Ying" <ying.huang@...el.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/swap: avoid a xa load for swapout path

On Tue, Oct 17, 2023 at 09:17:28AM +0800, Kairui Song wrote:
> From: Kairui Song <kasong@...cent.com>
> 
> A variable is never used for swapout path (shadowp is NULL) and compiler
> is unable to optimize out the unneeded load since it's a function call.
> 
> Signed-off-by: Kairui Song <kasong@...cent.com>

Reviewed-by: Matthew Wilcox (Oracle)

Possibly worth adding a reference to
3852f6768ede ("mm/swapcache: support to handle the shadow entries")

Not sure it's worth a Fixes:, but that's where it was introduced.