linux-kernel - Re: [PATH v5 3/3] iommu/vt-d: debugfs: Support dumping a specified page table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <74e3348c-e02a-7b78-beef-9bcf16b8c7f7@intel.com>
Date:   Tue, 17 Oct 2023 11:02:08 +0800
From:   "Liu, Jingqi" <jingqi.liu@...el.com>
To:     Baolu Lu <baolu.lu@...ux.intel.com>, <iommu@...ts.linux.dev>,
        Tian Kevin <kevin.tian@...el.com>,
        Joerg Roedel <joro@...tes.org>, Will Deacon <will@...nel.org>,
        Robin Murphy <robin.murphy@....com>
CC:     <linux-kernel@...r.kernel.org>
Subject: Re: [PATH v5 3/3] iommu/vt-d: debugfs: Support dumping a specified
 page table


On 10/16/2023 11:04 AM, Baolu Lu wrote:
> On 10/13/23 9:58 PM, Jingqi Liu wrote:
>>
......
>> +        if (scalable) {    /* scalable mode */
>> +            struct pasid_dir_entry *dir_tbl, *dir_entry;
>> +            struct pasid_entry *pasid_tbl, *pasid_tbl_entry;
>> +            u16 pasid_dir_size, dir_idx, tbl_idx, pgtt;
>> +            u64 pasid_dir_ptr;
>
> 0day robot complained:
>
>    drivers/iommu/intel/debugfs.c: In function 
> 'domain_translation_struct_show':
> >> drivers/iommu/intel/debugfs.c:401:29: warning: variable 
> 'pasid_dir_size' set but not used [-Wunused-but-set-variable]
>      401 |                         u16 pasid_dir_size, dir_idx, 
> tbl_idx, pgtt;
>          |                             ^~~~~~~~~~~~~~
>
> I have removed pasid_dir_size and queue the whole series for v6.7.
>
Thanks Baolu.
Indeed. It's an unused variable.

BR,
Jingqi
> Thank you!
>
> Best regards,
> baolu