linux-kernel - Re: [PATCH] cxl/pmu: Ensure put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <652ea9afdf5b_2b0d2929417@iweiny-mobl.notmuch>
Date:   Tue, 17 Oct 2023 08:35:11 -0700
From:   Ira Weiny <ira.weiny@...el.com>
To:     Dave Jiang <dave.jiang@...el.com>, Ira Weiny <ira.weiny@...el.com>,
        Davidlohr Bueso <dave@...olabs.net>,
        Jonathan Cameron <jonathan.cameron@...wei.com>,
        Alison Schofield <alison.schofield@...el.com>,
        Vishal Verma <vishal.l.verma@...el.com>,
        Dan Williams <dan.j.williams@...el.com>
CC:     <linux-cxl@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] cxl/pmu: Ensure put_device on pmu devices

Dave Jiang wrote:
> 
> 

[snip]

> > 
> > Properly call device_unregister() to free up the memory associated with
> > the device.
> > 
> > Fixes: 1ad3f701c399 ("cxl/pci: Find and register CXL PMU devices")
> > Cc: Jonathan Cameron <Jonathan.Cameron@...wei.com>
> > Signed-off-by: Ira Weiny <ira.weiny@...el.com>
> 
> Reviewed-by: Dave Jiang <dave.jiang@...el.com>
> 
> Although I wonder if we can just give device_unregister() to devm_add_action_or_reset() directly. 
> 

No because the action callback takes void * and device_unregister() takes
a struct device *.

Ira

[snip]