linux-kernel - Re: [PATCH] cxl/pmu: Ensure put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ae0860d6-198c-4d82-a7a6-8d0656c9070c@intel.com>
Date:   Tue, 17 Oct 2023 09:21:32 -0700
From:   Dave Jiang <dave.jiang@...el.com>
To:     Ira Weiny <ira.weiny@...el.com>,
        Davidlohr Bueso <dave@...olabs.net>,
        Jonathan Cameron <jonathan.cameron@...wei.com>,
        Alison Schofield <alison.schofield@...el.com>,
        Vishal Verma <vishal.l.verma@...el.com>,
        "Dan Williams" <dan.j.williams@...el.com>
CC:     <linux-cxl@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] cxl/pmu: Ensure put_device on pmu devices



On 10/17/23 08:35, Ira Weiny wrote:
> Dave Jiang wrote:
>>
>>
> 
> [snip]
> 
>>>
>>> Properly call device_unregister() to free up the memory associated with
>>> the device.
>>>
>>> Fixes: 1ad3f701c399 ("cxl/pci: Find and register CXL PMU devices")
>>> Cc: Jonathan Cameron <Jonathan.Cameron@...wei.com>
>>> Signed-off-by: Ira Weiny <ira.weiny@...el.com>
>>
>> Reviewed-by: Dave Jiang <dave.jiang@...el.com>
>>
>> Although I wonder if we can just give device_unregister() to devm_add_action_or_reset() directly. 
>>
> 
> No because the action callback takes void * and device_unregister() takes
> a struct device *.

Ah right! I knew there was a reason for the wrapper....
> 
> Ira
> 
> [snip]