[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2a96e3a8-48a5-46ae-9a0c-b5f2def0a257@linuxfoundation.org>
Date: Tue, 17 Oct 2023 09:46:47 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: zhujun2 <zhujun2@...s.chinamobile.com>, shuah@...nel.org
Cc: linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] selftests/efivarfs: create-read: fix a resource leak
On 10/16/23 20:33, zhujun2 wrote:
> The opened file should be closed in main(), otherwise resource
> leak will occur
>
Did you find this by code reading or by any other means. Please
add how you found the problem to the change log.
> Signed-off-by: zhujun2 <zhujun2@...s.chinamobile.com>
> ---
> tools/testing/selftests/efivarfs/create-read.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/tools/testing/selftests/efivarfs/create-read.c b/tools/testing/selftests/efivarfs/create-read.c
> index 9674a1939..6812104a5 100644
> --- a/tools/testing/selftests/efivarfs/create-read.c
> +++ b/tools/testing/selftests/efivarfs/create-read.c
> @@ -32,8 +32,11 @@ int main(int argc, char **argv)
> rc = read(fd, buf, sizeof(buf));
> if (rc != 0) {
> fprintf(stderr, "Reading a new var should return EOF\n");
> + close(fd);
> return EXIT_FAILURE;
> }
>
> + close(fd);
> +
No need for this extra line here.
> return EXIT_SUCCESS;
> }
thanks,
-- Shuah
Powered by blists - more mailing lists