linux-kernel - [PATCH] selftests/efivarfs: create-read: fix a resource leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20231017023335.7874-1-zhujun2@cmss.chinamobile.com>
Date:   Mon, 16 Oct 2023 19:33:35 -0700
From:   zhujun2 <zhujun2@...s.chinamobile.com>
To:     shuah@...nel.org
Cc:     linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
        zhujun2@...s.chinamobile.com
Subject: [PATCH] selftests/efivarfs: create-read: fix a resource leak

The opened file should be closed in main(), otherwise resource
leak will occur

Signed-off-by: zhujun2 <zhujun2@...s.chinamobile.com>
---
 tools/testing/selftests/efivarfs/create-read.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tools/testing/selftests/efivarfs/create-read.c b/tools/testing/selftests/efivarfs/create-read.c
index 9674a1939..6812104a5 100644
--- a/tools/testing/selftests/efivarfs/create-read.c
+++ b/tools/testing/selftests/efivarfs/create-read.c
@@ -32,8 +32,11 @@ int main(int argc, char **argv)
 	rc = read(fd, buf, sizeof(buf));
 	if (rc != 0) {
 		fprintf(stderr, "Reading a new var should return EOF\n");
+		close(fd);
 		return EXIT_FAILURE;
 	}
 
+	close(fd);
+
 	return EXIT_SUCCESS;
 }
-- 
2.17.1