linux-kernel - Re: [PATCH] dt-bindings: usb: vialab,vl817: remove reset-gpios from required list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <04ee08a4-e804-40fe-b24e-7a56c9e24e8b@linaro.org>
Date:   Tue, 17 Oct 2023 18:53:56 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Jisheng Zhang <jszhang@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Anand Moon <linux.amoon@...il.com>
Cc:     linux-usb@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: usb: vialab,vl817: remove reset-gpios from
 required list

On 17/10/2023 18:01, Jisheng Zhang wrote:
> The "reset-gpios" is optional in real case, for example reset pin is
> is hard wired to "high". And this fact is also reflected by the
> devm_gpio_get_optional() calling in driver code.
> 
> Signed-off-by: Jisheng Zhang <jszhang@...nel.org>
> ---
>  .../bindings/usb/thead,th1520-usb.yaml        | 42 ++++++++++---------
>  .../devicetree/bindings/usb/vialab,vl817.yaml |  1 -
>  2 files changed, 23 insertions(+), 20 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/usb/thead,th1520-usb.yaml b/Documentation/devicetree/bindings/usb/thead,th1520-usb.yaml
> index afb618eb5013..ce1cab75f0ff 100644
> --- a/Documentation/devicetree/bindings/usb/thead,th1520-usb.yaml
> +++ b/Documentation/devicetree/bindings/usb/thead,th1520-usb.yaml
> @@ -28,6 +28,10 @@ properties:
>  
>    ranges: true
>  
> +  thead,misc-syscon:
> +    $ref: /schemas/types.yaml#/definitions/phandle-array
> +    description: a phandle to the misc system register controller syscon node.

Either you combined two unrelated changes or this should be resets from
reset-controller.


Best regards,
Krzysztof