linux-kernel - Re: [PATCH] dt-bindings: usb: vialab,vl817: remove reset-gpios from required list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZS/zBvaWicGAeaGq@xhacker>
Date:   Wed, 18 Oct 2023 23:00:22 +0800
From:   Jisheng Zhang <jszhang@...nel.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Anand Moon <linux.amoon@...il.com>, linux-usb@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: usb: vialab,vl817: remove reset-gpios from
 required list

On Tue, Oct 17, 2023 at 06:53:56PM +0200, Krzysztof Kozlowski wrote:
> On 17/10/2023 18:01, Jisheng Zhang wrote:
> > The "reset-gpios" is optional in real case, for example reset pin is
> > is hard wired to "high". And this fact is also reflected by the
> > devm_gpio_get_optional() calling in driver code.
> > 
> > Signed-off-by: Jisheng Zhang <jszhang@...nel.org>
> > ---
> >  .../bindings/usb/thead,th1520-usb.yaml        | 42 ++++++++++---------
> >  .../devicetree/bindings/usb/vialab,vl817.yaml |  1 -
> >  2 files changed, 23 insertions(+), 20 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/usb/thead,th1520-usb.yaml b/Documentation/devicetree/bindings/usb/thead,th1520-usb.yaml
> > index afb618eb5013..ce1cab75f0ff 100644
> > --- a/Documentation/devicetree/bindings/usb/thead,th1520-usb.yaml
> > +++ b/Documentation/devicetree/bindings/usb/thead,th1520-usb.yaml
> > @@ -28,6 +28,10 @@ properties:
> >  
> >    ranges: true
> >  
> > +  thead,misc-syscon:
> > +    $ref: /schemas/types.yaml#/definitions/phandle-array
> > +    description: a phandle to the misc system register controller syscon node.
> 
> Either you combined two unrelated changes or this should be resets from
> reset-controller.

oops, this change isn't expected... I was working on TH1520 usb but
add local changes step by step, but then found vl817 need to be patched.
I forgot to reset TH1520 usb part. Sorry for noise. V2 will be sent out
soon.