linux-kernel - Re: [PATCH v8 15/23] drm/mediatek: Manage component's clock with function pointers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <714697a54f449cbc78620f7482ca78173fc94230.camel@mediatek.com>
Date:   Tue, 17 Oct 2023 10:50:14 +0000
From:   Shawn Sung (宋孝謙) 
        <Shawn.Sung@...iatek.com>
To:     CK Hu (胡俊光) <ck.hu@...iatek.com>,
        "matthias.bgg@...il.com" <matthias.bgg@...il.com>,
        "angelogioacchino.delregno@...labora.com" 
        <angelogioacchino.delregno@...labora.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>
CC:     Yongqiang Niu (牛永强) 
        <yongqiang.niu@...iatek.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-mediatek@...ts.infradead.org" 
        <linux-mediatek@...ts.infradead.org>,
        "chunkuang.hu@...nel.org" <chunkuang.hu@...nel.org>,
        Jason-JH Lin (林睿祥) 
        <Jason-JH.Lin@...iatek.com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        Nancy Lin (林欣螢) <Nancy.Lin@...iatek.com>,
        Moudy Ho (何宗原) <Moudy.Ho@...iatek.com>,
        "daniel@...ll.ch" <daniel@...ll.ch>,
        "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
        "mchehab@...nel.org" <mchehab@...nel.org>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        Nathan Lu (呂東霖) <Nathan.Lu@...iatek.com>,
        "airlied@...il.com" <airlied@...il.com>,
        "sean@...rly.run" <sean@...rly.run>,
        "hverkuil-cisco@...all.nl" <hverkuil-cisco@...all.nl>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "fshao@...omium.org" <fshao@...omium.org>,
        "johnson.wang@...iatek.corp-partner.google.com" 
        <johnson.wang@...iatek.corp-partner.google.com>
Subject: Re: [PATCH v8 15/23] drm/mediatek: Manage component's clock with
 function pointers

Hi Angelo,

On Tue, 2023-10-17 at 11:47 +0200, AngeloGioacchino Del Regno wrote:
> Il 16/10/23 12:40, Hsiao Chien Sung ha scritto:
> > By registering component related functions to the pointers,
> > we can easily manage them within a for-loop and simplify the
> > logic of clock control significantly.
> > 
> > Reviewed-by: CK Hu <ck.hu@...iatek.com>
> > Signed-off-by: Hsiao Chien Sung <shawn.sung@...iatek.com>
> > ---
> >   .../gpu/drm/mediatek/mtk_disp_ovl_adaptor.c   | 111 +++++++----
> > -------
> >   1 file changed, 44 insertions(+), 67 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl_adaptor.c
> > b/drivers/gpu/drm/mediatek/mtk_disp_ovl_adaptor.c
> > index 60e5dfe9ef0d..fffef2a4f919 100644
> > --- a/drivers/gpu/drm/mediatek/mtk_disp_ovl_adaptor.c
> > +++ b/drivers/gpu/drm/mediatek/mtk_disp_ovl_adaptor.c
> > @@ -53,6 +53,7 @@ struct ovl_adaptor_comp_match {
> >   	enum mtk_ovl_adaptor_comp_type type;
> >   	enum mtk_ddp_comp_id comp_id;
> >   	int alias_id;
> > +	const struct mtk_ddp_comp_funcs *funcs;
> >   };
> >   
> >   struct mtk_disp_ovl_adaptor {
> > @@ -67,20 +68,35 @@ static const char * const
> > private_comp_stem[OVL_ADAPTOR_TYPE_NUM] = {
> >   	[OVL_ADAPTOR_TYPE_MERGE]	= "merge",
> >   };
> >   
> > +static const struct mtk_ddp_comp_funcs _ethdr = {
> 
> Sorry I just noticed that; can you please remove the leading "_" from
> all
> of those?
> 
> _ethdr -> ethdr or mtk_ethdr
> _merge -> merge or mtk_merge
> _rdma  -> rdma  or mtk_rdma
> 
> Thanks,
> Angelo
> 

Sure. Will do in the next version.
The reason I didn't use mtk_* is simply because of the column width
will exceed 100 characaters.

Thanks,
Shawn