linux-kernel - Re: [PATCH] ASoC: dt-bindings: tas5805m: Disallow undefined properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231017-blinking-barricade-9e068a5fc602@spud>
Date:   Tue, 17 Oct 2023 11:50:42 +0100
From:   Conor Dooley <conor@...nel.org>
To:     Rob Herring <robh@...nel.org>
Cc:     Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Daniel Beer <daniel.beer@...rinstitute.com>,
        alsa-devel@...a-project.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: dt-bindings: tas5805m: Disallow undefined
 properties

On Mon, Oct 16, 2023 at 10:55:47AM -0500, Rob Herring wrote:
> Device specific bindings should not allow undefined properties. This is
> accomplished in json-schema with 'additionalProperties: false'.
> 
> Examples should be last in the schema, so move additionalProperties up
> while we're here.
> 
> Signed-off-by: Rob Herring <robh@...nel.org>

Acked-by: Conor Dooley <conor.dooley@...rochip.com>

Thanks,
Conor.

> ---
>  Documentation/devicetree/bindings/sound/tas5805m.yaml | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/sound/tas5805m.yaml b/Documentation/devicetree/bindings/sound/tas5805m.yaml
> index 63edf52f061c..12c41974274e 100644
> --- a/Documentation/devicetree/bindings/sound/tas5805m.yaml
> +++ b/Documentation/devicetree/bindings/sound/tas5805m.yaml
> @@ -37,6 +37,8 @@ properties:
>        generated from TI's PPC3 tool.
>      $ref: /schemas/types.yaml#/definitions/string
>  
> +additionalProperties: false
> +
>  examples:
>    - |
>      i2c {
> @@ -52,5 +54,4 @@ examples:
>                  ti,dsp-config-name = "mono_pbtl_48khz";
>          };
>      };
> -
> -additionalProperties: true
> +...
> -- 
> 2.42.0
> 
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)