linux-kernel - Re: [PATCH] amd64: Fix csum_partial_copy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iLSKJroojadGD2hvec8EyeUA5TPMKd=PmBzCJ7h2HF0zA@mail.gmail.com>
Date:   Wed, 18 Oct 2023 09:36:25 +0200
From:   Eric Dumazet <edumazet@...gle.com>
To:     gus Gusenleitner Klaus <gus@...a.com>,
        Noah Goldstein <goldstein.w.n@...il.com>
Cc:     lkml <linux-kernel@...r.kernel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, "bp@...en8.de" <bp@...en8.de>,
        "dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>,
        "x86@...nel.org" <x86@...nel.org>, "hpa@...or.com" <hpa@...or.com>,
        "David S. Miller" <davem@...emloft.net>,
        "dsahern@...nel.org" <dsahern@...nel.org>,
        "kuba@...nel.org" <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH] amd64: Fix csum_partial_copy_generic()

On Wed, Oct 18, 2023 at 8:18 AM gus Gusenleitner Klaus <gus@...a.com> wrote:
>
> The checksum calculation is wrong in case of an source buffer
> containing zero bytes only. The expected return value is 0, the
> actual return value is 0xfffffff.
>
> This problem occurs when a ICMP echo reply is sent that has set
> zero identifier, sequence number and data.
>
> Signed-off-by: Klaus Gusenleitner <gus@...a.com>
> ---
>  arch/x86/lib/csum-copy_64.S | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/lib/csum-copy_64.S b/arch/x86/lib/csum-copy_64.S
> index d9e16a2cf285..c8391b4f3dea 100644
> --- a/arch/x86/lib/csum-copy_64.S
> +++ b/arch/x86/lib/csum-copy_64.S
> @@ -44,7 +44,7 @@ SYM_FUNC_START()
>         movq  %r13, 3*8(%rsp)
>         movq  %r15, 4*8(%rsp)
>
> -       movl  $-1, %eax
> +       movl  $0, %eax
>         xorl  %r9d, %r9d
>         movl  %edx, %ecx
>         cmpl  $8, %ecx
> --
> 2.30.2
>

Lets CC Noah Goldstein <goldstein.w.n@...il.com> (I thought Noah wrote
some kunit tests, maybe I am wrong)

When was this bug added ?

A Fixes: tag is very much needed, and would be a needed step to CC the
original author.

Thanks.