[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2023101853-axis-stylist-f1b9@gregkh>
Date: Wed, 18 Oct 2023 09:45:18 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Karolina Stolarek <karolina.stolarek@...el.com>
Cc: Julia Lawall <julia.lawall@...ia.fr>,
kenechukwu maduechesi <maduechesik@...il.com>,
outreachy@...ts.linux.dev, shreeya.patel23498@...il.com,
linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rts5208: Replace delay function.
On Wed, Oct 18, 2023 at 09:32:46AM +0200, Karolina Stolarek wrote:
> On 18.10.2023 09:03, Julia Lawall wrote:
> >
> >
> > On Tue, 17 Oct 2023, kenechukwu maduechesi wrote:
> >
> > > Replace udelay() with usleep_range() for more precise delay handling.
> > >
> > > Reported by checkpatch:
> > >
> > > CHECK: usleep_range is preferred over udelay
> >
> > This message is typically not a good candidate for outreachy patches,
> > because you need access to the device to be sure that any change is
> > correct.
>
> Could we add a paragraph on how to pick good checkpatch.pl error to fix to
> the Outreachyfirstpatch docs? This could go to "Find a driver to clean up"
> section, for example.
The ability to find a "good" error changes over time, so this might be
hard to do.
good luck!
greg k-h
Powered by blists - more mailing lists