linux-kernel - Re: [PATCH] staging: rts5208: Replace delay function.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7dde176b-1059-e9a4-a023-0243cce61d01@intel.com>
Date:   Wed, 18 Oct 2023 09:52:36 +0200
From:   Karolina Stolarek <karolina.stolarek@...el.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:     Julia Lawall <julia.lawall@...ia.fr>,
        kenechukwu maduechesi <maduechesik@...il.com>,
        <outreachy@...ts.linux.dev>, <shreeya.patel23498@...il.com>,
        <linux-staging@...ts.linux.dev>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: rts5208: Replace delay function.

On 18.10.2023 09:45, Greg Kroah-Hartman wrote:
> On Wed, Oct 18, 2023 at 09:32:46AM +0200, Karolina Stolarek wrote:
>> On 18.10.2023 09:03, Julia Lawall wrote:
>>>
>>>
>>> On Tue, 17 Oct 2023, kenechukwu maduechesi wrote:
>>>
>>>> Replace udelay() with usleep_range() for more precise delay handling.
>>>>
>>>> Reported by checkpatch:
>>>>
>>>> CHECK: usleep_range is preferred over udelay
>>>
>>> This message is typically not a good candidate for outreachy patches,
>>> because you need access to the device to be sure that any change is
>>> correct.
>>
>> Could we add a paragraph on how to pick good checkpatch.pl error to fix to
>> the Outreachyfirstpatch docs? This could go to "Find a driver to clean up"
>> section, for example.
> 
> The ability to find a "good" error changes over time, so this might be
> hard to do.

I agree, but we can all agree that experimenting with udelay during 
Outreachy is not a good idea, and people should know about it

All the best,
Karolina

> 
> good luck!
> 
> greg k-h