[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <cdcd0b8a-1098-470f-86ba-dcc858ac4cd3@nutanix.com>
Date: Wed, 18 Oct 2023 13:49:17 +0100
From: Chris Riches <chris.riches@...anix.com>
To: Rinat Gadelshin <rgadelsh@...il.com>, audit@...r.kernel.org,
Paul Moore <paul@...l-moore.com>,
Eric Paris <eparis@...hat.com>
Cc: jonathan.davies@...anix.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] audit: Send netlink ACK before setting connection in
auditd_set
On 18/10/2023 13:11, Rinat Gadelshin wrote:
>> -static void audit_receive(struct sk_buff *skb)
>> +static void audit_receive(struct sk_buff *skb)
>> {
>> struct nlmsghdr *nlh;
>> + bool ack;
> Maybe we should initialize 'ack' as 'true' here?
That doesn't feel particularly useful to me. In fact, I think it's
actually clearer
uninitialised as a never-used initialisation could look like an
actually-used default.
We're guaranteed to initialise before use.
- Chris
Powered by blists - more mailing lists