linux-kernel - Re: [PATCH v2] audit: Send netlink ACK before setting connection in auditd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9b82b0df-c4a9-40bc-8980-ac2494073fcd@gmail.com>
Date:   Wed, 18 Oct 2023 16:19:06 +0300
From:   Rinat Gadelshin <rgadelsh@...il.com>
To:     Chris Riches <chris.riches@...anix.com>, audit@...r.kernel.org,
        Paul Moore <paul@...l-moore.com>,
        Eric Paris <eparis@...hat.com>
Cc:     jonathan.davies@...anix.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] audit: Send netlink ACK before setting connection in
 auditd_set

On 18.10.2023 15:49, Chris Riches wrote:
>
> On 18/10/2023 13:11, Rinat Gadelshin wrote:
>>> -static void audit_receive(struct sk_buff *skb)
>>> +static void audit_receive(struct sk_buff *skb)
>>>   {
>>>       struct nlmsghdr *nlh;
>>> +    bool ack;
>> Maybe we should initialize 'ack' as 'true' here?
> That doesn't feel particularly useful to me. In fact, I think it's 
> actually clearer
> uninitialised as a never-used initialisation could look like an 
> actually-used default.
> We're guaranteed to initialise before use.
>
> - Chris

Sorry, you are right.
I've missed the following line:

ack = nlh->nlmsg_flags & NLM_F_ACK;

- Rinat