linux-kernel - Re: [RESEND PATCH 1/1] mcb: fix error handling for different scenarios when parsing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2023101912-unloaded-escalate-1060@gregkh>
Date:   Thu, 19 Oct 2023 20:34:41 +0200
From:   "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
To:     Sanjuán García, Jorge 
        <Jorge.SanjuanGarcia@...gon.com>
Cc:     "morbidrsa@...il.com" <morbidrsa@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "jth@...nel.org" <jth@...nel.org>,
        Rodríguez Barbarin, José Javier 
        <josejavier.rodriguez@...gon.com>,
        "yangyingliang@...wei.com" <yangyingliang@...wei.com>
Subject: Re: [RESEND PATCH 1/1] mcb: fix error handling for different
 scenarios when parsing

On Thu, Oct 19, 2023 at 02:15:34PM +0000, Sanjuán García, Jorge wrote:
> chameleon_parse_gdd() may fail for different reasons and end up
> in the err tag. Make sure we at least always free the mcb_device
> allocated with mcb_alloc_dev().
> 
> If mcb_device_register() fails, make sure to give up the reference
> in the same place the device was added.
> 
> Fixes: 728ac3389296 ("mcb: mcb-parse: fix error handing in chameleon_parse_gdd()")
> Reviewed-by: Jose Javier Rodriguez Barbarin <JoseJavier.Rodriguez@...gon.com>
> Signed-off-by: Jorge Sanjuan Garcia <jorge.sanjuangarcia@...gon.com>
> ---
>  drivers/mcb/mcb-core.c  | 1 +
>  drivers/mcb/mcb-parse.c | 2 +-
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mcb/mcb-core.c b/drivers/mcb/mcb-core.c
> index 2f23b9c3b751..f797d078978f 100644
> --- a/drivers/mcb/mcb-core.c
> +++ b/drivers/mcb/mcb-core.c
> @@ -247,6 +247,7 @@ int mcb_device_register(struct mcb_bus *bus, struct mcb_device *dev)
>  	return 0;
>  
>  out:
> +	put_device(&dev->dev);
>  
>  	return ret;
>  }
> diff --git a/drivers/mcb/mcb-parse.c b/drivers/mcb/mcb-parse.c
> index 656b6b71c768..1ae37e693de0 100644
> --- a/drivers/mcb/mcb-parse.c
> +++ b/drivers/mcb/mcb-parse.c
> @@ -106,7 +106,7 @@ static int chameleon_parse_gdd(struct mcb_bus *bus,
>  	return 0;
>  
>  err:
> -	put_device(&mdev->dev);
> +	mcb_free_dev(mdev);
>  
>  	return ret;
>  }
> -- 
> 2.34.1


Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- You have marked a patch with a "Fixes:" tag for a commit that is in an
  older released kernel, yet you do not have a cc: stable line in the
  signed-off-by area at all, which means that the patch will not be
  applied to any older kernel releases.  To properly fix this, please
  follow the documented rules in the
  Documentation/process/stable-kernel-rules.rst file for how to resolve
  this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot