[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20231019191519.jksgyzv6gcrtltbs@reidt-HP-Z2>
Date: Thu, 19 Oct 2023 14:15:19 -0500
From: reidt <reidt@...com>
To: Vaishnav Achath <vaishnav.a@...com>
CC: <vigneshr@...com>, <nm@...com>, <kristo@...nel.org>,
<krzysztof.kozlowski+dt@...aro.org>, <afd@...com>,
<devicetree@...r.kernel.org>,
<linux-arm-kernel@...ts.infradead.org>,
<linux-kernel@...r.kernel.org>, <robh+dt@...nel.org>,
<u-kumar1@...com>
Subject: Re: [PATCH v4 2/2] arm64: dts: ti: k3-j7200-mcu-wakeup: Update fss
node and hbmc_mux
On 13:54-20231009, Vaishnav Achath wrote:
> From: Nishanth Menon <nm@...com>
>
> FSS node claims to be a syscon node, while it actually is a simple bus
> where OSPI, HBMC peripherals are located and a mux for path select
> between OSPI and Hyperbus which can be modelled as a reg-mux. So model
> it accordingly and use reg-mux to describe the hbmc_mux.
>
> Signed-off-by: Nishanth Menon <nm@...com>
> Signed-off-by: Vaishnav Achath <vaishnav.a@...com>
> ---
>
> V2->V3:
> * Keep register regions unchanged as it is correct according to memory
> map.
> * Update commit messages as per Vignesh's suggestion.
>
> V1->V2:
> * Address feedback from Udit to limit the FSS register region size as
> per TRM.
> * Use reg-mux changes to simplify the hbmc-mux modelling.
> * Update commit message to reflect changes.
>
> Depends on:
> https://lore.kernel.org/all/20230911151030.71100-1-afd@ti.com/
>
> arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi
> index 2ee6215e38a6..4f98ea685d33 100644
> --- a/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi
> @@ -507,15 +507,16 @@
> status = "disabled";
> };
>
> - fss: syscon@...00000 {
> - compatible = "syscon", "simple-mfd";
> + fss: bus@...00000 {
> + compatible = "simple-bus";
> reg = <0x00 0x47000000 0x00 0x100>;
> #address-cells = <2>;
> #size-cells = <2>;
> ranges;
>
> - hbmc_mux: hbmc-mux {
> - compatible = "mmio-mux";
> + hbmc_mux: mux-controller@...00004 {
> + compatible = "reg-mux";
> + reg = <0x00 0x47000004 0x00 0x2>;
> #mux-control-cells = <1>;
> mux-reg-masks = <0x4 0x2>; /* HBMC select */
> };
> --
> 2.17.1
>
>
Reviewed-by: Reid Tonking <reidt@...com>
Powered by blists - more mailing lists