linux-kernel - Re: [PATCH v4 1/2] arm64: dts: ti: k3-j7200-mcu-wakeup: Switch mcu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <33e958fb-71b9-43b2-911c-a187651a0de4@ti.com>
Date:   Thu, 19 Oct 2023 16:05:08 -0500
From:   Andrew Davis <afd@...com>
To:     Vaishnav Achath <vaishnav.a@...com>, <vigneshr@...com>,
        <nm@...com>, <kristo@...nel.org>,
        <krzysztof.kozlowski+dt@...aro.org>
CC:     <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <robh+dt@...nel.org>,
        <u-kumar1@...com>
Subject: Re: [PATCH v4 1/2] arm64: dts: ti: k3-j7200-mcu-wakeup: Switch
 mcu_syscon to ti,j721e-system-controller

On 10/9/23 3:24 AM, Vaishnav Achath wrote:
> From: Nishanth Menon <nm@...com>
> 
> Use ti,j721e-system-controller to be explicit about the syscon node we
> are using.
> 
> Signed-off-by: Nishanth Menon <nm@...com>
> Signed-off-by: Vaishnav Achath <vaishnav.a@...com>
> ---
> 
> No changes since V1.
> 
>   arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi
> index 6ffaf85fa63f..2ee6215e38a6 100644
> --- a/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi
> @@ -165,7 +165,7 @@
>   	};
>   
>   	mcu_conf: syscon@...00000 {
> -		compatible = "syscon", "simple-mfd";
> +		compatible = "ti,j721e-system-controller", "syscon", "simple-mfd";

There is already a "ti,j721e-system-controller" in the main domain dtsi. And this
is not one of those. You are hiding a valid DT warning by adding an incorrect
compatible string that just so happens to not throw the warning.

This should be a "simple-bus" node.

Andrew

>   		reg = <0x00 0x40f00000 0x00 0x20000>;
>   		#address-cells = <1>;
>   		#size-cells = <1>;