linux-kernel - [PATCH] mmc: block: Use octal for file permissions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 19 Oct 2023 16:57:52 -0300
From:   Edson Juliano Drosdeck <edson.drosdeck@...il.com>
To:     ulf.hansson@...aro.org
Cc:     adrian.hunter@...el.com, CLoehle@...erstone.com,
        brauner@...nel.org, axboe@...nel.dk,
        victor.shih@...esyslogic.com.tw, f.fainelli@...il.com,
        asuk4.q@...il.com, yibin.ding@...soc.com,
        linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org,
        edson.drosdeck@...il.com
Subject: [PATCH] mmc: block: Use octal for file permissions

Octal permissions are preferred as stated in
Documentation/dev-tools/checkpatch.rst. Replace symbolic permissions
with octal permissions when creating the files.

Signed-off-by: Edson Juliano Drosdeck <edson.drosdeck@...il.com>
---
 drivers/mmc/core/block.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/core/block.c b/drivers/mmc/core/block.c
index b5b414a71e0b..edb653d8fbfa 100644
--- a/drivers/mmc/core/block.c
+++ b/drivers/mmc/core/block.c
@@ -2916,7 +2916,7 @@ static void mmc_blk_add_debugfs(struct mmc_card *card, struct mmc_blk_data *md)
 
 	if (mmc_card_mmc(card)) {
 		md->ext_csd_dentry =
-			debugfs_create_file("ext_csd", S_IRUSR, root, card,
+			debugfs_create_file("ext_csd", 0400, root, card,
 					    &mmc_dbg_ext_csd_fops);
 	}
 }
-- 
2.39.2