linux-kernel - Re: [PATCH] mmc: block: Use octal for file permissions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 23 Oct 2023 13:42:20 +0200
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     Edson Juliano Drosdeck <edson.drosdeck@...il.com>
Cc:     adrian.hunter@...el.com, CLoehle@...erstone.com,
        brauner@...nel.org, axboe@...nel.dk,
        victor.shih@...esyslogic.com.tw, f.fainelli@...il.com,
        asuk4.q@...il.com, yibin.ding@...soc.com,
        linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mmc: block: Use octal for file permissions

On Thu, 19 Oct 2023 at 21:58, Edson Juliano Drosdeck
<edson.drosdeck@...il.com> wrote:
>
> Octal permissions are preferred as stated in
> Documentation/dev-tools/checkpatch.rst. Replace symbolic permissions
> with octal permissions when creating the files.
>
> Signed-off-by: Edson Juliano Drosdeck <edson.drosdeck@...il.com>

Thanks for your patch!

Replacing symbolic permissions with octal permissions makes sense to
me. However, I don't want one patch per line that needs to be changed.

Instead, please go over all the files in drivers/mmc/core and fix all
of them in one patch. Another patch can be done for
drivers/mmc/hosts/*

Kind regards
Uffe

> ---
>  drivers/mmc/core/block.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/core/block.c b/drivers/mmc/core/block.c
> index b5b414a71e0b..edb653d8fbfa 100644
> --- a/drivers/mmc/core/block.c
> +++ b/drivers/mmc/core/block.c
> @@ -2916,7 +2916,7 @@ static void mmc_blk_add_debugfs(struct mmc_card *card, struct mmc_blk_data *md)
>
>         if (mmc_card_mmc(card)) {
>                 md->ext_csd_dentry =
> -                       debugfs_create_file("ext_csd", S_IRUSR, root, card,
> +                       debugfs_create_file("ext_csd", 0400, root, card,
>                                             &mmc_dbg_ext_csd_fops);
>         }
>  }
> --
> 2.39.2
>