linux-kernel - Re: [PATCH v2 2/2] staging: vme_user: Use __func_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZTGgVNBoxOtWOuE8@ashyti-mobl2.lan>
Date:   Thu, 19 Oct 2023 23:32:04 +0200
From:   Andi Shyti <andi.shyti@...ux.intel.com>
To:     Soumya Negi <soumya.negi97@...il.com>
Cc:     Andi Shyti <andi.shyti@...ux.intel.com>,
        Martyn Welch <martyn@...chs.me.uk>,
        Manohar Vanga <manohar.vanga@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Julia Lawall <julia.lawall@...ia.fr>,
        outreachy@...ts.linux.dev, linux-kernel@...r.kernel.org,
        linux-staging@...ts.linux.dev
Subject: Re: [PATCH v2 2/2] staging: vme_user: Use __func__ instead of
 function name

Hi Soumya,

> > On Thu, Oct 19, 2023 at 12:20:10AM -0700, Soumya Negi wrote:
> > > Replace function names in message strings with __func__ to fix
> > > all checkpatch warnings like:
> > > 
> > >     WARNING: Prefer using '"%s...", __func__' to using 'vme_lm_get',
> > >              this function's name, in a string
> > > 
> > > Signed-off-by: Soumya Negi <soumya.negi97@...il.com>
> > 
> > you forgot my ack here:
> > 
> > Acked-by: Andi Shyti <andi.shyti@...ux.intel.com> 
> > 
> > Andi
> 
> Sorry I forgot the tag Andi. I'll add the tags in v3(Greg has suggested
> more changes). There will be some new patches, so I'll leave the tags out in 
> those as you may want to review them first.

no problem.

I don't see reviews from Greg in this v2 series. If you are
referring to the changelog, then you don't need to resend.

Andi