linux-kernel - Re: [PATCH v2 2/2] staging: vme_user: Use __func_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231019221355.GC3017@Negi>
Date:   Thu, 19 Oct 2023 15:13:55 -0700
From:   Soumya Negi <soumya.negi97@...il.com>
To:     Andi Shyti <andi.shyti@...ux.intel.com>
Cc:     Martyn Welch <martyn@...chs.me.uk>,
        Manohar Vanga <manohar.vanga@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Julia Lawall <julia.lawall@...ia.fr>,
        outreachy@...ts.linux.dev, linux-kernel@...r.kernel.org,
        linux-staging@...ts.linux.dev
Subject: Re: [PATCH v2 2/2] staging: vme_user: Use __func__ instead of
 function name

On Thu, Oct 19, 2023 at 11:32:04PM +0200, Andi Shyti wrote:
> Hi Soumya,
> 
> > > On Thu, Oct 19, 2023 at 12:20:10AM -0700, Soumya Negi wrote:
> > > > Replace function names in message strings with __func__ to fix
> > > > all checkpatch warnings like:
> > > > 
> > > >     WARNING: Prefer using '"%s...", __func__' to using 'vme_lm_get',
> > > >              this function's name, in a string
> > > > 
> > > > Signed-off-by: Soumya Negi <soumya.negi97@...il.com>
> > > 
> > > you forgot my ack here:
> > > 
> > > Acked-by: Andi Shyti <andi.shyti@...ux.intel.com> 
> > > 
> > > Andi
> > 
> > Sorry I forgot the tag Andi. I'll add the tags in v3(Greg has suggested
> > more changes). There will be some new patches, so I'll leave the tags out in 
> > those as you may want to review them first.
> 
> no problem.
> 
> I don't see reviews from Greg in this v2 series. If you are
> referring to the changelog, then you don't need to resend.
> 
> Andi

Hi Andi,

I had sent in v2 after suggestions from Julia and Greg. Got some more
feedback from Greg in the v1 email thread though. Will have to send a v3 due 
to that.

Regards,
Soumya