linux-kernel - Re: [PATCH v2] dt-bindings: serial: 8250

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdUkPiA=o_QLyuwsTYW7y1ksCjHAqyNSHFx2QZ-dP-HGsQ@mail.gmail.com>
Date:   Thu, 19 Oct 2023 12:09:06 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Francesco Dolcini <francesco@...cini.it>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Vignesh Raghavendra <vigneshr@...com>,
        linux-serial@...r.kernel.org, devicetree@...r.kernel.org,
        Francesco Dolcini <francesco.dolcini@...adex.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] dt-bindings: serial: 8250_omap: add rs485-rts-active-high

Hi Francesco,

On Wed, May 31, 2023 at 1:14 PM Francesco Dolcini <francesco@...cini.it> wrote:
> From: Francesco Dolcini <francesco.dolcini@...adex.com>
>
> Add rs485-rts-active-high property, this was removed by mistake.
> In general we just use rs485-rts-active-low property, however the OMAP
> UART for legacy reason uses the -high one.
>
> Fixes: 767d3467eb60 ("dt-bindings: serial: 8250_omap: drop rs485 properties")
> Closes: https://lore.kernel.org/all/ZGefR4mTHHo1iQ7H@francesco-nb.int.toradex.com/
> Signed-off-by: Francesco Dolcini <francesco.dolcini@...adex.com>
> ---
> v2: removed reported-by

Thanks for your patch, which is now commit 403e97d6ab2cb6fd
("dt-bindings: serial: 8250_omap: add rs485-rts-active-high")
in v6.4-rc5.

> --- a/Documentation/devicetree/bindings/serial/8250_omap.yaml
> +++ b/Documentation/devicetree/bindings/serial/8250_omap.yaml
> @@ -70,6 +70,7 @@ properties:
>    dsr-gpios: true
>    rng-gpios: true
>    dcd-gpios: true
> +  rs485-rts-active-high: true

make dt_binding_check complains:

    Documentation/devicetree/bindings/serial/8250_omap.yaml:
rs485-rts-active-high: missing type definition

This property should have been added to
Documentation/devicetree/bindings/serial/serial.yaml first.

>    rts-gpio: true
>    power-domains: true
>    clock-frequency: true

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds