linux-kernel - Re: [PATCH] scsi: snici: Remove dead code in snic_dr_clean_pending

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <15081b01-2915-42a4-bcda-0d8243741baa@kadam.mountain>
Date:   Thu, 19 Oct 2023 13:09:27 +0300
From:   Dan Carpenter <dan.carpenter@...aro.org>
To:     Su Hui <suhui@...china.com>
Cc:     kartilak@...co.com, sebaddel@...co.com, jejb@...ux.ibm.com,
        martin.petersen@...cle.com, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] scsi: snici: Remove dead code in
 snic_dr_clean_pending_req

On Thu, Oct 19, 2023 at 04:30:27PM +0800, Su Hui wrote:
> Value stored to 'ret' is never read, remove it to save space.
> 
> Signed-off-by: Su Hui <suhui@...china.com>

Could you do this a bit more thouroughly and remove all the
"ret = FAILED;" and "ret = 0;" assignments.  Just "return FAILED;"
and "return 0;" directly.

regards,
dan carpenter