linux-kernel - Re: [PATCH] scsi: snici: Remove dead code in snic_dr_clean_pending

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1d380712-2d08-9ac5-fff9-f13fb4e9aaa9@nfschina.com>
Date:   Fri, 20 Oct 2023 09:52:06 +0800
From:   Su Hui <suhui@...china.com>
To:     Dan Carpenter <dan.carpenter@...aro.org>
Cc:     kartilak@...co.com, sebaddel@...co.com, jejb@...ux.ibm.com,
        martin.petersen@...cle.com, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] scsi: snici: Remove dead code in
 snic_dr_clean_pending_req

On 2023/10/19 18:09, Dan Carpenter wrote:
> On Thu, Oct 19, 2023 at 04:30:27PM +0800, Su Hui wrote:
>> Value stored to 'ret' is never read, remove it to save space.
>>
>> Signed-off-by: Su Hui <suhui@...china.com>
> Could you do this a bit more thouroughly and remove all the
> "ret = FAILED;" and "ret = 0;" assignments.  Just "return FAILED;"
> and "return 0;" directly.
Yes, this is better, thanks for your advice.
I will send v2 later.

Su Hui