linux-kernel - Re: [PATCH v7 01/13] ASoC: SOF: core: Ensure sof_ops_free() is still called when probe never ran.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87pm1alpwb.wl-tiwai@suse.de>
Date:   Thu, 19 Oct 2023 15:09:56 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>
Cc:     alsa-devel@...a-project.org, Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Cezary Rojewski <cezary.rojewski@...el.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        Liam Girdwood <liam.r.girdwood@...ux.intel.com>,
        Peter Ujfalusi <peter.ujfalusi@...ux.intel.com>,
        Bard Liao <yung-chuan.liao@...ux.intel.com>,
        Ranjani Sridharan <ranjani.sridharan@...ux.intel.com>,
        Kai Vehmanen <kai.vehmanen@...ux.intel.com>,
        Mark Brown <broonie@...nel.org>,
        Daniel Baluta <daniel.baluta@....com>,
        linux-kernel@...r.kernel.org, sound-open-firmware@...a-project.org
Subject: Re: [PATCH v7 01/13] ASoC: SOF: core: Ensure sof_ops_free() is still called when probe never ran.

On Thu, 19 Oct 2023 12:02:55 +0200,
Maarten Lankhorst wrote:
> 
> Hey,
> 
> Den 2023-10-13 kl. 11:15, skrev Takashi Iwai:
> > On Mon, 09 Oct 2023 13:54:25 +0200,
> > Maarten Lankhorst wrote:
> >> In an effort to not call sof_ops_free twice, we stopped running it when
> >> probe was aborted.
> >> 
> >> Check the result of cancel_work_sync to see if this was the case.
> >> 
> >> Fixes: 31bb7bd9ffee ("ASoC: SOF: core: Only call sof_ops_free() on remove if the probe was successful")
> >> Cc: Peter Ujfalusi <peter.ujfalusi@...ux.intel.com>
> >> Acked-by: Mark Brown <broonie@...nel.org>
> > Your Signed-off-by tag is missing.
> > 
> > Could you resubmit?
> > 
> > 
> > thanks,
> > 
> > Takashi
> 
> I missed this email apparently.
> 
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>
> 
> Is this enough for the tooling, or do you need an actual resubmit?

That's enough, and I applied the series to for-next branch now.


thanks,

Takashi