linux-kernel - Re: [PATCH 1/2] printk: Check valid console index for preferred console

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZTEuRfrbdAlx6PPf@alley>
Date:   Thu, 19 Oct 2023 15:25:25 +0200
From:   Petr Mladek <pmladek@...e.com>
To:     Tony Lindgren <tony@...mide.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Steven Rostedt <rostedt@...dmis.org>,
        John Ogness <john.ogness@...utronix.de>,
        Sergey Senozhatsky <senozhatsky@...omium.org>,
        Jiri Slaby <jirislaby@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] printk: Check valid console index for preferred
 console

On Thu 2023-10-12 09:42:56, Tony Lindgren wrote:
> Let's check for valid console index values for preferred console to avoid
> bogus console index numbers from kernel command line.
> 
> Let's also return an error for negative index numbers for the preferred
> console. Unlike for device drivers, a negative index is not valid for the
> preferred console.
> 
> Let's also constify idx while at it.
> 
> Signed-off-by: Tony Lindgren <tony@...mide.com>

Makes sense:

Reviewed-by: Petr Mladek <pmladek@...e.com>

Best Regards,
Petr