linux-kernel - Re: [PATCH iwl-next 4/6] i40e: Use DECLARE_BITMAP for flags field in i40e

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4e78e68f-139c-4a30-ae7b-60eadab9f13c@intel.com>
Date:   Fri, 20 Oct 2023 14:29:29 -0700
From:   Jacob Keller <jacob.e.keller@...el.com>
To:     Ivan Vecera <ivecera@...hat.com>, <netdev@...r.kernel.org>
CC:     <mschmidt@...hat.com>, <dacampbe@...hat.com>, <poros@...hat.com>,
        "Jesse Brandeburg" <jesse.brandeburg@...el.com>,
        Tony Nguyen <anthony.l.nguyen@...el.com>,
        "David S. Miller" <davem@...emloft.net>,
        "Eric Dumazet" <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        "moderated list:INTEL ETHERNET DRIVERS" 
        <intel-wired-lan@...ts.osuosl.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH iwl-next 4/6] i40e: Use DECLARE_BITMAP for flags field in
 i40e_hw



On 10/20/2023 12:37 PM, Ivan Vecera wrote:
> Convert flags field in i40e_hw from u64 to bitmap and its usage
> to use bit access functions and rename the field to 'caps' as
> this field describes capabilities that are set once on init and
> read many times later.
> 
> Changes:
> - Convert "hw_ptr->flags & FLAG" to "test_bit(FLAG, ...)"
> - Convert "hw_ptr->flags |= FLAG" to "set_bit(FLAG, ...)"
> - Convert "hw_ptr->flags &= ~FLAG" to "clear_bit(FLAG, ...)"
> - Rename i40e_hw.flags to i40e_hw.caps
> - Rename i40e_set_hw_flags() to i40e_set_hw_caps()
> - Adjust caps names so they are prefixed by I40E_HW_CAP_ and existing
>   _CAPABLE suffixes are stripped
> 
> Signed-off-by: Ivan Vecera <ivecera@...hat.com>

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>