linux-kernel - Re: [PATCH iwl-next 5/6] i40e: Consolidate hardware capabilities

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6ecee6b6-1735-4fa5-b2b4-3ba93dfc6e4a@intel.com>
Date:   Fri, 20 Oct 2023 14:34:50 -0700
From:   Jacob Keller <jacob.e.keller@...el.com>
To:     Ivan Vecera <ivecera@...hat.com>, <netdev@...r.kernel.org>
CC:     <mschmidt@...hat.com>, <dacampbe@...hat.com>, <poros@...hat.com>,
        "Jesse Brandeburg" <jesse.brandeburg@...el.com>,
        Tony Nguyen <anthony.l.nguyen@...el.com>,
        "David S. Miller" <davem@...emloft.net>,
        "Eric Dumazet" <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Richard Cochran <richardcochran@...il.com>,
        "moderated list:INTEL ETHERNET DRIVERS" 
        <intel-wired-lan@...ts.osuosl.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH iwl-next 5/6] i40e: Consolidate hardware capabilities



On 10/20/2023 12:37 PM, Ivan Vecera wrote:
> Fields .caps in i40e_hw and .hw_features in i40e_pf both indicate
> capabilities provided by hardware. Move and merge i40e_pf.hw_features
> into i40e_hw.caps as this is more appropriate place for them and
> adjust their names to I40E_HW_CAP_... convention.
> 
> Signed-off-by: Ivan Vecera <ivecera@...hat.com>

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>

The hw features values were originally introduced by commit b74f571f59a8
("i40e/i40evf: organize and re-number feature flags") (v4.15), and were
previously part of the normal flags back then.

The hw flags field was used since 07f89be81fa5 ("i40e: Fix basic support
for X722 devices") (v4.5), and appears to have been extended a few times
since its original.

Its good to clean these up and keep them together conceptionally. Thanks!