linux-kernel - Re: [PATCH] virtio-crypto: handle config changed by work queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20231020045844-mutt-send-email-mst@kernel.org>
Date:   Fri, 20 Oct 2023 04:59:03 -0400
From:   "Michael S. Tsirkin" <mst@...hat.com>
To:     Herbert Xu <herbert@...dor.apana.org.au>
Cc:     zhenwei pi <pizhenwei@...edance.com>, arei.gonglei@...wei.com,
        linux-crypto@...r.kernel.org, jasowang@...hat.com,
        linux-kernel@...r.kernel.org, Halil Pasic <pasic@...ux.ibm.com>
Subject: Re: [PATCH] virtio-crypto: handle config changed by work queue

On Fri, Oct 20, 2023 at 01:50:05PM +0800, Herbert Xu wrote:
> On Sat, Oct 07, 2023 at 02:43:09PM +0800, zhenwei pi wrote:
> > MST pointed out: config change callback is also handled incorrectly
> > in this driver, it takes a mutex from interrupt context.
> > 
> > Handle config changed by work queue instead.
> > 
> > Cc: Gonglei (Arei) <arei.gonglei@...wei.com>
> > Cc: Halil Pasic <pasic@...ux.ibm.com>
> > Cc: Michael S. Tsirkin <mst@...hat.com>
> > Signed-off-by: zhenwei pi <pizhenwei@...edance.com>
> > ---
> >  drivers/crypto/virtio/virtio_crypto_common.h |  3 +++
> >  drivers/crypto/virtio/virtio_crypto_core.c   | 14 +++++++++++++-
> >  2 files changed, 16 insertions(+), 1 deletion(-)
> 
> Patch applied.  Thanks.


It's in my tree too, but git should be able to figure it out.

> -- 
> Email: Herbert Xu <herbert@...dor.apana.org.au>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt