linux-kernel - Re: [PATCH] coresight-tpdm: Correct the property name of MSR number

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2bc15792-78f7-4498-b397-d8cf6053d864@linaro.org>
Date:   Fri, 20 Oct 2023 10:59:33 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Tao Zhang <quic_taozha@...cinc.com>,
        Mathieu Poirier <mathieu.poirier@...aro.org>,
        Suzuki K Poulose <suzuki.poulose@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Konrad Dybcio <konradybcio@...il.com>,
        Mike Leach <mike.leach@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
Cc:     Jinlong Mao <quic_jinlmao@...cinc.com>,
        Leo Yan <leo.yan@...aro.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        coresight@...ts.linaro.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        Tingwei Zhang <quic_tingweiz@...cinc.com>,
        Yuanfang Zhang <quic_yuanfang@...cinc.com>,
        Trilok Soni <quic_tsoni@...cinc.com>,
        Hao Zhang <quic_hazha@...cinc.com>,
        linux-arm-msm@...r.kernel.org, andersson@...nel.org
Subject: Re: [PATCH] coresight-tpdm: Correct the property name of MSR number

On 20/10/2023 10:13, Tao Zhang wrote:
>>> diff --git a/drivers/hwtracing/coresight/coresight-tpdm.c b/drivers/hwtracing/coresight/coresight-tpdm.c
>>> index b25284e..97654aa 100644
>>> --- a/drivers/hwtracing/coresight/coresight-tpdm.c
>>> +++ b/drivers/hwtracing/coresight/coresight-tpdm.c
>>> @@ -892,7 +892,7 @@ static int tpdm_probe(struct amba_device *adev, const struct amba_id *id)
>>>   
>>>   	if (drvdata && tpdm_has_dsb_dataset(drvdata))
>>>   		of_property_read_u32(drvdata->dev->of_node,
>>> -			   "qcom,dsb_msr_num", &drvdata->dsb_msr_num);
>>> +			   "qcom,dsb-msrs-num", &drvdata->dsb_msr_num);
>> So you never tested your DTS... We can keep asking about this but still
>> testing does not happen :/
> 
> Since this new property has not been applied on the exist upstream DTS, 
> I tested this driver with the
> 
> local DTS. Unfortunately, the property name in the local DTS is not 
> updated, this is why it is not found

But your local DTS would not pass dtbs_check tests, so that's why I am
saying - you never tested it on mainline kernel.

Best regards,
Krzysztof