linux-kernel - Re: [PATCH 1/2] nvme: common: make keyring and auth separate modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b3fd6ccd-c00a-4de0-ad5e-383f6e4c0e54@suse.de>
Date:   Fri, 20 Oct 2023 15:42:30 +0200
From:   Hannes Reinecke <hare@...e.de>
To:     Arnd Bergmann <arnd@...nel.org>, Keith Busch <kbusch@...nel.org>,
        Jens Axboe <axboe@...nel.dk>, Christoph Hellwig <hch@....de>,
        Sagi Grimberg <sagi@...mberg.me>,
        Chaitanya Kulkarni <kch@...dia.com>
Cc:     Arnd Bergmann <arnd@...db.de>, linux-kernel@...r.kernel.org,
        linux-nvme@...ts.infradead.org
Subject: Re: [PATCH 1/2] nvme: common: make keyring and auth separate modules

On 10/20/23 15:05, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> When only the keyring module is included but auth is not, modpost
> complains about the lack of a module license tag:
> 
> ERROR: modpost: missing MODULE_LICENSE() in drivers/nvme/common/nvme-common.o
> 
> Address this by making both modules buildable standalone,
> removing the now unnecessary CONFIG_NVME_COMMON symbol
> in the process.
> 
> Fixes: 9d77eb5277849 ("nvme-keyring: register '.nvme' keyring")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>   drivers/nvme/Makefile         | 2 +-
>   drivers/nvme/common/Kconfig   | 4 ++--
>   drivers/nvme/common/Makefile  | 7 ++++---
>   drivers/nvme/common/keyring.c | 2 ++
>   drivers/nvme/host/Kconfig     | 2 --
>   drivers/nvme/target/Kconfig   | 2 --
>   include/linux/nvme-keyring.h  | 2 +-
>   7 files changed, 10 insertions(+), 11 deletions(-)
> 
Reviewed-by: Hannes Reinecke <hare@...e.de>

Cheers,

Hannes